(Not for review) split stor modules#8
Open
anujkumar93 wants to merge 27 commits intomasterfrom
Open
Conversation
Initial support for DNAnexus paths with stor (represented as `DXPath` objects). See documentation for more details! Sem-Ver: api-break
* release notes for dx * updating release ntoe * release notes fix Co-Authored-By: anujkumar93 <anujkumar.maverick@gmail.com> * release docs review comments addressed * Sem-Ver: api-break * retriggering travis build
* wait_on_close on open dxpath and updating fixtures * Addressed review comments
* Implemented normpath and changed urllib to requests * Addressed review comments * review changes in comments
* Only allow bytes for write_object in Python 3 Sem-Ver: api-break * Update warning for clarity
* Remove swift_upload_options / kwargs / etc * simplify open() to only allow mode and encoding as arguments. Sem-Ver: api-break * Fix extra kwargs to write_object * Simplifying suggestion * Remove upload kwargs from test
…-split_modules
* open fix for swift and s3 * added test for open fix * retriggering travis
* made wait_on_close default to 0 and added docs * addressed review comments
…-split_modules
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the sum total of changes required to convert singular stor package into 4 packages: stor, stor_swift, stor_dx, stor_s3. Need to redo all these changes because need to open smaller PRs.
Can't open smaller PRs with already existing code because
counsyl:dnanexusbranch was deleted, so can't fork from it, andcounsyl:masterhas a single DNAnexus v1 commit. So can't find common ancestors across the two since they diverged. This is the closest to making it merge cleanly. Yep, lel. If anybody does reach this, out of the 401 files changed, 301 are vrpy fixtures (*.yaml) which need no review, about half the files were only renamed, so only about ~50 files have reviewable changes.